Matthew Roeschke

Results 465 comments of Matthew Roeschke

Appears on the pandas side, there's some agreement that pandas nullable-int dtype should match the pandas non-nullable int dtype for this operation, although it differs from numpy: https://github.com/pandas-dev/pandas/issues/48223 ``` In...

In the 1 / 0 case, pandas has special logic to take the `1 / 0 = 0` result from numpy and replace it with inf https://github.com/pandas-dev/pandas/blob/e0cf2645095a5164ea7a7b143097bf0051f11481/pandas/core/ops/missing.py#L130 For non divide...

Thanks for tracking this. Yes, a failure summary like `pytest`'s would be really helpful.

One potential difficulty before implementing this: We note for EA authors that there is a set of test that can be run to check EA compatibility: https://pandas.pydata.org/docs/development/extending.html#testing-extension-arrays So if tests...

If `infer_datetime_format` was deprecated, I do like @rhshadrach's suggestion https://github.com/pandas-dev/pandas/pull/48621#issuecomment-1250390925 of making `guess_datetime_format` public such that existing "functionality" isn't lost while making `to_datetime` stricter as the prior behavior would be...

Thanks for the report. This may be tricky to address. A row of the data with `extract_links=None` is just strings that the `TextFileReader` will infer types of: ``` ... ['1)',...

Thanks for the report! I was able to replicate this issue as well.

One point of note: the `Series` constructor wasn't necessarily intended to accept a `pa.array` and a `pd.ArrowDtype`, but I suppose this should be supported as well.

`arrays.ArrowExtensionArray` was also added to the public API and would probably be the most explicit way to create a pandas object from arrow array: https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.arrays.ArrowExtensionArray.html I'll make sure there's some...

Noting that this was fixed by https://github.com/pandas-dev/pandas/pull/48489/files and should be fixed when 1.5 is released. Just needs a unit test