pandas icon indicating copy to clipboard operation
pandas copied to clipboard

SAS7BDAT parser: Fix page count

Open jonashaag opened this issue 3 years ago • 1 comments

While page size is 32 bits (https://github.com/Roche/pyreadstat/blob/e0627c7cf406e4296a9af16036a563719fcba237/src/sas/readstat_sas.c#L245) the page count is word size (https://github.com/Roche/pyreadstat/blob/e0627c7cf406e4296a9af16036a563719fcba237/src/sas/readstat_sas.c#L270-L284).

Unfortunately I don't have a test file that I can share.

  • [ ] closes #xxxx (Replace xxxx with the Github issue number)
  • [ ] Tests added and passed if fixing a bug or adding a new feature
  • [ ] All code checks passed.
  • [ ] Added type annotations to new arguments/methods/functions.
  • [ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

jonashaag avatar Aug 08 '22 07:08 jonashaag

Hmm maybe we can modify an existing test file and read the page count attribute from the parser. Not really an end to end test but the best idea I have

jonashaag avatar Aug 08 '22 21:08 jonashaag

@mroeschke do you prefer the kind of test I suggested to no test?

jonashaag avatar Sep 02 '22 18:09 jonashaag

@mroeschke do you prefer the kind of test I suggested to no test?

Yeah your suggested test would be good too add, thanks.

mroeschke avatar Sep 02 '22 22:09 mroeschke

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

github-actions[bot] avatar Oct 03 '22 00:10 github-actions[bot]

@jonashaag could you merge in main one more time? This looked okay

mroeschke avatar Oct 04 '22 18:10 mroeschke

See #48764 instead

jonashaag avatar Oct 04 '22 18:10 jonashaag

See #48764 instead

Cool that one looks better. Okay to close this then?

mroeschke avatar Oct 04 '22 18:10 mroeschke