SAS7BDAT parser: Fix page count
While page size is 32 bits (https://github.com/Roche/pyreadstat/blob/e0627c7cf406e4296a9af16036a563719fcba237/src/sas/readstat_sas.c#L245) the page count is word size (https://github.com/Roche/pyreadstat/blob/e0627c7cf406e4296a9af16036a563719fcba237/src/sas/readstat_sas.c#L270-L284).
Unfortunately I don't have a test file that I can share.
- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] Tests added and passed if fixing a bug or adding a new feature
- [ ] All code checks passed.
- [ ] Added type annotations to new arguments/methods/functions.
- [ ] Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.
Hmm maybe we can modify an existing test file and read the page count attribute from the parser. Not really an end to end test but the best idea I have
@mroeschke do you prefer the kind of test I suggested to no test?
@mroeschke do you prefer the kind of test I suggested to no test?
Yeah your suggested test would be good too add, thanks.
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.
@jonashaag could you merge in main one more time? This looked okay
See #48764 instead
See #48764 instead
Cool that one looks better. Okay to close this then?