Morgan Roderick comments

Results 93 comments of


                                            Morgan Roderick

Should we implement automated releases?

> Hello @mroderick, > > As I want to step back-in now that I've got time to contribute again, here's my 2 cents on this matter. > > We've been...

Name differences

Thank you for pointing it out! I agree, there should be more consistency in naming. I think an approach like this could work: * create a `README` or wiki page,...

Sandbox promise reset also clear promiseLibrary

With the current behaviour (`reset` resets everything), it is inconvenient and non-obvious to have to tell the sandbox about the promise implementation after each `reset`. If we change the behaviour...

returnValue of calls is out of order when spying on recursive functions

I edited the description to add language annotations to the the fenced blocks to allow GFM to do syntax highlighting

Cannot spy on property getters, and stubbed getters do not record calls

Thank you for your contribution! This is a curious issue. I too was under the impression that calls were being recorded, but something seems amiss. Your example shows the issue...

Cannot spy on property getters, and stubbed getters do not record calls

> @mroderick, I can help out with this. That would be great, thank you!

Cannot spy on property getters, and stubbed getters do not record calls

@jshado1 that would be great, thank you

Behaviour of deep matching inconsistent between arrays and objects.

I've added a "pinned" label, which tells stale bot to back off

Extract sandbox and fake into separate modules

All I would need from a package would be `sandbox` and `fake`.

Extract sandbox and fake into separate modules

> I'm just expressing my opinion. That is very valuable! Please keep doing that!