Morgan Roderick

Results 93 comments of Morgan Roderick

I’ve pinned this issue, so it doesn’t get closed by Stale bot

If we do decide to go down this road, then I think we should use something like https://github.com/gajus/eslint-plugin-jsdoc ... the rules should probably go into `eslint-config-sinon`.

I've tried to start this effort in https://github.com/sinonjs/samsam/pull/82. Your comments welcome, please post them on that PR.

Documentation would be a great start. Then we can explore options for making better/easier integrations with the test frameworks that people use. I'd prefer to keep integrations in separate package(s),...

@Crimson-riot that would be great! If you run into difficulties, feel free to ask questions in this issue and the maintainers will do their best to help you out

> Thanks! I think I have a basic pr up, but wasn't too entirely sure which releases to add this small documentation to so as a first pass I added...

I have verified the existence locally. Don't yet know if it is a recent addition, or if it was always failing. I'll try to find some time for a `git...

I've managed to construct a smaller test case to produce the error ```js const sinon = require("sinon"); let spy = sinon.spy(); spy(5, 100); // passes spy.calledOnceWithExactly(spy.getCall(0), 5, 100) // throws...

> Any way of adding a regression test to show the bug? That's a fair question. We haven't detected it thus far with tests and users have also not reported...

> Before someone says we are only supporting native Promises, let's investigate what they do! That's a [strawman fallacy](https://yourlogicalfallacyis.com/strawman). You know well enough that we support promise libraries, as you...