Morgan Roderick

Results 93 comments of Morgan Roderick

> How about a simple string grep and ignore on match? E.g. `--ignore-grep "[bot]"`. If we can add multiple of these, then that would solve the problem for me 👍

Anyone with a bit of git skills should be able to find the contributors of a project just fine, even when maintainers are forgetful, make mistakes or use imperfect tools....

> Why do we maintain the `AUTHORS` file in Sinon btw? We just adopted the practice of keeping it up to date. Things were different 10 years ago. ![2020-02-18 at...

> maybe it's something that should rather be handled by dedicated tools instead, which can then be consumed by anyone that prefers to have the info in `package.json` In Sinon...

I'd be happy to adopt conventional commits (and even accept squashing over rebasing), if that means we can have more/better automation. We should probably review the protection settings to prevent...

It looks like there is some progress being made in Node's test runner: https://github.com/nodejs/node/pull/52848/files#diff-7ef19622f4f1c831ca0e6ed0edc03cb517f16969f1f1b0972a117bd3fa65c44aR1963-R1990. Is that a viable path forwards for you?

Thank you for the pull request 👏 There are still a few things to do. When I run this locally, I get this report: ``` $ npm run knip >...

@mantoni the [errors seen in `ubuntu-latest`](https://github.com/sinonjs/sinon/actions/runs/12502499977/job/34881594651) might also affect Mochify running on latest Chrome + Ubuntu. If you're seeing similar errors in Mochify, you might want to stick to `ubuntu-22.04`...

That would be a significant undertaking. What would be the benefits of doing that?