Morgan Roderick

fix: actaully reset 'injectedKeys'

3

Re-assigning the local variable `injectedKeys` would not change `sandbox.injectedKeys`, thus `restoreContext` doesn't fully restore the context. See: https://lgtm.com/projects/g/sinonjs/sinon/snapshot/9e09e7d79bac5808ca98fac4f7419a20be4fc43d/files/lib/sinon/sandbox.js?sort=name&dir=ASC&mode=heatmap#x9f770d565ef51b7d:1

Proposal: publish to npm using scopes

7

I think it would make sense to start using scopes when we publish things to npm. * `sinon` => `@sinonjs/sinon` * `nise` => `@sinonjs/nise` * `lolex` => `@sinonjs/lolex` * `sinon-test`...

Proposal: documentation overhaul and hostnames

17

I think it's time for a major overhaul of the documentation of the `sinon` package, to make it easier to understand. I'd like **all** our projects to have good documentation....

Should we implement automated releases?

2

#1656 was caused by me overlooking a manual step when preparing the release. This has likely happened before, and will likely happen again. I think we should consider implementing automated...

The failure from `FormData` is caused by `jsdom-global`, which removes it in the cleanup. See https://github.com/rstacruz/jsdom-global/blob/master/keys.js#L122 The `jsdom-global` looks pretty dead. A quick fix would be to fork it and...

Publish as @sinonjs/nise

5

This package should be published as `@sinonjs/nise`, and the existing package deprecated.

Document improvements from #35

1

We need to update the documentation to include the changes made in #35

chore: Prefer async functions

2

Since the codebase already uses async/await and requires node 14+, it might as well use async/await instead of then for Promises By using async/await we can reduce the indentation levels,...

.throws with no message creates error with empty message

7

When calling `throwsException` with a `String` as the `error` argument and no `message` argument, it will create errors with an empty message as seen in the code sample below. ```js...

fix: node 18|20 compatibility

1

In Node 18+ `FormData` and `FileReader` have been removed. This PR adds a polyfill for `FormData` and updates the feature detection around `Blob` and `FileReader` to work in Node 18+.