Martin Robinson
Martin Robinson
Out of curiosity, what kind of results do you see before and after when running Speedometer 2.1?
> Does that mean that every embedder will need to add Webdriver support code? I think this makes sense to some extent. For instance Webdriver can open and close `WebView`s....
> It's better to make WebDriver independent of ServoShell, as WebDriver shouldn't depend on any specific embedder. I still think it isn't a good idea to make it totally independent....
> Is there a clearer illustration / doc of what the relation between servoshell and web driver is, and what the relation should be? Yes, sorry for the confusion. The...
> Another question: besides lifetime management, is there other communication needed between WebDriver and servoshell? That's a good question. I'm not exactly sure of the answer here. I think it...
> Anyway, I agree that we can send all through embedder first for synchronization purpose. It may help later. I think for these type of commands we can add a...
Apologies for not getting to this one yet. I will look at it first thing tomorrow morning.
I added some minor rustdoc comments and did a little re-ordering of members. Sending to the merge queue now. Thanks @longvatrong111!
1. Why is this necessary? The PR description just repeats what the title and code does. 2. Is there a specification for this behavior? 3. Can you add a test...
Let's add some tests for LCP. This is a good moment to do that. Why don't we need this behavior on other types of navigations? Why just reloads?