Martin Robinson
Martin Robinson
Looks like a good fix, but I want to double-check the removal of these two unrelated CSS rules before landing.
Here's what I had to do to reproduce this issue for future reference: 1. Switch the system theme to a dark theme. 2. Start servoshell (the servoshell page doesn't have...
> * `RunningAppState::notify_focus_changed` should not hide the unfocused webviews, considering the possibility that multiple webview instances are simultaneously visible in the foreground. It might be better to leave `hide` operation...
This is a great point. These should not be synchronous.
I think all prompts are fully asynchronous now.
@burhankhanzada Are you only seeing this in winit_minimal? If so, that's expected behavior as winit_minimal only implement the bare minimum of integration with the system. I cannot reproduce this issue...
I added a note in the PR description about the two new WebGL failures. Summary: I think this change is important even though it causes a pretty minor regression in...
> Do we have any numbers of performance improvement? I can try to get some numbers tomorrow. Performance number might be hard to get (and I suspect that other things...
> I think that's reasonable, but we should document this (losing correctness for performance) in places were we are currently premultiplying and open a new issue about it (also link...
@sagudev I think I've responded to all of your comments. Thanks for the review. PTAL.