Martin Robinson
Martin Robinson
Is this still happening?
Sounds good to me. I would also remove the preference entirely.
Alternatively, I think it could be added to an `impl GlobalScope` block in `imagebitmap.rs` perhaps? We use this pattern a bit in layout.
I think that `strum` could also be useful for `IntoStaticStr` which would remove a lot of manually written "enum to string" code as well.
Since the property is disabled, perhaps it would make sense to implement this DOM API, but always return 1.0.
Your suggestion seems reasonable though maybe I would need to see your change to say for sure.
@mukilan Thanks for the review. I think I've addressed all your comments.
I'm not sure we can upgrade these requirements from within the Servo project. It looks like it is breaking the CI upstream: https://github.com/web-platform-tests/wpt/pull/55916
This is difficult to address as browser.html is no more.
@atouchet If we could make a minimized test case, perhaps a page with just one image that would be super useful!