Martin Robinson

Results 446 comments of Martin Robinson

We should also clean up any parsed trees if they are destroyed or disconnected from the DOM.

It's possible that something should be triggering a rendering update, but isn't. Before this issue might have been hidden by the fact that rendering updates were triggered at *every* event...

Yes, the logic uses substring matching to determine if a particular test is marked as flaky.

I think this is up to the embedder to fix honestly. As far as I know the UI shown isn't part of web content, but part of the browser chrome....

@jdm Did you write a patch for this locally that you plan to upload? If not I'm happy to tackle this one as part of my layout work.

CC @delan who I think had some ideas for moving away from tracing for profiling, though I could be misremembering.

The issue here seems to be that we are not setting `deltaMode` here properly.

Indeed. We convert lines to pixels, but still report that the delta mode was in lines: https://github.com/servo/servo/blob/949ce5523bd519f0bf6581a3ebc2714653b2a7b5/ports/servoshell/desktop/headed_window.rs#L702