Martin Robinson

Results 446 comments of Martin Robinson

> Would it matter if Unix sockets performed worse than Mach ports on macOS, given that Unix performance is gated by Unix sockets performance? I think it would be an...

> I see. If I interpret the rest of the comment correctly, it sounds like you may not be in favour of switching from Mach ports to Unix domain sockets...

> Can we deny [unsafe_op_in_unsafe_fn](https://doc.rust-lang.org/rustc/lints/listing/allowed-by-default.html#unsafe-op-in-unsafe-fn) in this file after this change, or are there still some cases of missing unsafe blocks? My plan was to fix remaining sites and then...

I think what's happening here is that the detection of single test runs isn't great. What we should likely do is to just use `--headless` by default unless `--no-headless` is...

I believe this does supersede #39291. We probably need to do a bit more work here: 1. Some actions should likely be done on the embedder process side so that...

> I expected that embedders would receive a set of items that just describe the context based on hit test and selection, like: > > * url of image >...

> In your model, how to you implement something like "Search for ..." when some text is selected, knowing that this should build a url based on the opensearch template...

> Knowing that the hit test contains a selection is not enough for a good UX if you need another roundtrip to fetch the selected content... either that will slow...

> > What we cannot do, I think, is to provide absolutely everything from the web content. > > Gecko does it, and that seems to work fine. Do you...

It's hard to say since it's intermittent, but this seemed like a good thing to do regardless. I don't think there are any tests that rely on the fact that...