Bill Collins
Bill Collins
I suspect the answer is "yarn pnp", but I'll try and put together a repro tomorrow - thanks.
The `NODE_OPTIONS` issue is actually a combo of yarn pnp and cross-env - still no idea on the hook spin https://github.com/mrginglymus/pw-eg Here's a repro - `test-ct` works, running with `cross-env`...
Ah, nice find, that looks like it indeed. Thanks for all the help.
Conditional exports are the best way to handle a lot of this as they achieve the desired goal (simple imports) without needing to configure full details in every tool (tsconfig,...
To a certain extent, yes, I would still need to precompute. This is because in my docgen process I extract a lot more information than is provided in `react-docgen-typescript` -...
> Rollup did do a better job of prompting for externals Yes rolldowns default behaviour of "Oh I couldn't find this it's probably fine" is...somewhat surprising!
So on Linux this is easily fixable by running the tests with `LC_ALL=en_US.UTF-8`. On windows....might be easier to just skip any tests that assert on Intl output...
...I was so obsessed with the presence of the comma I completely missed that point! Yes, fixing to `en_US` makes sense until you have translations ;)
A considerably simpler option is to drop tsdown, as it doesn't seem like it offers much benefit (on the current usage) over just compiling with tsc.
green \o/