drwpow
Fix rolldown config
Changes
- fixes #593
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
⚠️ No Changeset found
Latest commit: 479bf90149c7a542f9ebeac325b65f8dd24800de
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
A considerably simpler option is to drop tsdown, as it doesn't seem like it offers much benefit (on the current usage) over just compiling with tsc.
@drwpow is this mac os test a known flaky or something I've broken?
It’s known flaky. It has something to do with updating Vitest 3 → 4. There’s a job that tests build --watch which is a little complex, but up till now had been working no problem, and now there’s some hanging process that doesn’t shut down properly but only in the macos runner. I’ve poked at it a few times this week but haven’t solved it; I may just disable the watch test on mac 🤷.
(no nothing you broke 😛)
