Bill Collins
Bill Collins
This PR now includes tests for all currently supported frameworks. There are many that have now dropped from 100%, mostly I think those using JSX-like syntax. I've tried to check...
> Are there any open issues for this new case? > > There's at least [facebook/react#31689](https://github.com/facebook/react/issues/31689) for React, but it's closed. I've re-opened it. Is there somewhere in this repo...
If there's a chance that https://github.com/webcomponents/custom-elements-everywhere/pull/2474 might get merged soon, I'd rather that get merged before this - deconflicting this on top of that one will more pleasant than _vice...
Well there's a thing. Switching the sandbox to pnp masks the mdx type issue...somehow. It also throws up a _lot_ of other issues, as it's a shortcut to finding packages...
@ndelangen task failed successfully, at last: https://app.circleci.com/pipelines/github/storybookjs/storybook/104174/workflows/4910938e-9cef-493e-8c72-30c19fd7ffc9/jobs/893718 This job won't pass until https://github.com/storybookjs/storybook/pull/32442 is in.
@ndelangen if you're happy with the approach, then yes! we can add further storybooks on a case by case basis
@ndelangen updated. latest failures appears to be caused (ish) by https://github.com/storybookjs/storybook/issues/32822 - `storybook/test` types reference external packages (which appear to have undeclared type dependencies).
@ndelangen all green again! I guess sb10 is pulling in more test deps that are missing (upstream) their associated types.
Ah, it appears the problem is that https://github.com/parcel-bundler/lightningcss/blob/fc7f350e5b26188941778514a1f0c0ae48282e72/src/values/ident.rs#L34-L37 disallows idents with these reserved names. However, I'm not sure that that is required by the css modules spec; it's certainly not...
On further inspection, it seems like sass ate the fractions, but did at least emit with sufficient precision. However, forcing sass to emit the raw calc is a mite annoying,...