Bill Collins

Results 9 comments of Bill Collins

Having another look through the code, since the simplifications in https://github.com/jenkinsci/github-branch-source-plugin/pull/226 it may be that `validateMergeHash` could just return a `bool`.

This has been reverted in python for now: https://github.com/python/cpython/pull/17960

Is this something that the [Autograding plugin](https://plugins.jenkins.io/autograding/) does? I've not used it myself, but it's listed as a consumer of the checks API and seems to cover your usage. It...

hi @AlexVarchuk, I've created a minimal repro repo here: https://github.com/mrginglymus/redoc-type-bug I don't use CRA myself, but I think I've got everything right there. I'm going to raise a PR to...

Ah, this looks like we can probably apply the same fix for readonly as nullable. I'll raise a new PR.

Ahh, I've just seen https://github.com/tfranzel/drf-spectacular/issues/520 I think these are valid concerns, and that's why I didn't also extract from path parameters. However, the key issue is that there is currently...

Hi, sorry for letting this slide! I did find the recommendation in #8453 shortly after raising this PR, and found the DRF spectacular already does nearly everything from this PR,...

Here's a minimal repro: https://stackblitz.com/edit/github-mqgxvo?file=.storybook%2Fpreview.js The console warning appears when clicking the 'Click me!' in the toolbar.

~This seems to have been fixed in 4.9.0 (or thereabouts - I went from 4.8.2 and 4.9.2 and no longer neede the patch).~ My apologies; the problematic dependency was updated...