Bill Collins

Results 88 comments of Bill Collins

Unfortunately the line from typescript appears to be "Don't have type errors in your public API": https://github.com/microsoft/TypeScript/issues/38628

Closing in favour of https://github.com/storybookjs/storybook/pull/32447

Alas, it seems that the experimental `experimentalDts` option lacks intersectionality with the also experimental `dts.resolve` option, used to inline external types. So, while this produces more accurate typings, it's not...

See also https://github.com/storybookjs/storybook/discussions/31554

It appears that `@storybook/test` is attempting to patch a type in `@storybook/core`: https://github.com/storybookjs/storybook/blob/d8260421bed5d80f5cc261d462630e07c1f5deca/code/lib/test/src/index.ts#L25 But, as you are unlikely to have `@storybook/core` in your deps, this doesn't do anything on PnP....

Urgh - I get completely different errors between windows and linux :)

> @valentinpalkovic @mrginglymus > > We should try: > > > Does the output be stable if you set `treeshake.moduleSideEffects: false`? That made me realise that none of the build...

Either way, still no luck - it's still failing to bundle babel correctly

Aha - looks like rolldown-plugin-dts might be having trouble resolving `definitely-typed` packages. If you replace this line: https://github.com/storybookjs/storybook/blob/0484989616b84eb1b1680a0414827752ad3b8012/code/core/src/babel/index.ts#L40 with ```ts export type { GeneratorOptions } from '@types/babel__generator'; ``` then it...

Repro: https://github.com/mrginglymus/rd-dts-dt