Martin Raspaud comments

Results 496 comments of


                                            Martin Raspaud

A new reader for the netcdf sent to Icare by Meteo-France.

@lperier the error that is now in the tests is because of an external issue. If you merge your branch with main, it should disappear.

Introduce the newly chosen standard name

My understanding was that an executive decision should be made to choose the standard name, and that I needed to be the one making decision. As we go for "oblique_reflectance"...

Introduce the newly chosen standard name

Ok, I didn't realise going for "oblique_toa_bidirectional_reflectance" would be controversial, so let's pick the shortest of the two others for now : `product_of_cosine_solar_zenith_angle_and_toa_bidirectional_reflectance`

Introduce `oblique_reflectance` calibration

also the PR here is implementing this https://github.com/pytroll/satpy/pull/3292

Fix ahi_hsd cleanup during interpreter shutdown

Looking at the documentation, I don't see it clearly written that `weakref.finalize` would solve the problem you mention. Could you verify yourself that it does indeed work?

Fix ahi_hsd cleanup during interpreter shutdown

no, but I'm probably looking in the wrong place :) https://docs.python.org/3/reference/datamodel.html#object.__del__

Fix ahi_hsd cleanup during interpreter shutdown

Thanks for the link, I understand what finalize does here, so LGTM! I have to admit I'm a bit disappointed by `__del__`'s behaviour :) or I don't understand what it...

Add procedural solar_zenith_angle

So what do we do with this PR ? Do we still want procedural channels ?

Add procedural solar_zenith_angle

Sounds good, changing the milestone now

tlefile.py urlopen does not recognize celestar ssl certificate

Thank you for reporting this issue! I tested with the provided code example, and it does work for me?