A new reader for the netcdf sent to Icare by Meteo-France.
- [ ] Closes #xxxx
- [ ] Tests added
- [ ] Fully documented
- [ ] Add your name to
AUTHORS.mdif not there already
pre-commit.ci autofix
@lperier thanks for adding this reader!
As you can see, the CI is complaining about a few things, that would be nice to fix as many as possible.
Another important point is adding tests for this new reader. The way we do it nowadays is to generate a data file in a temporary directory (using pytest's tmp_path), run the reader and check what is being read.
@lperier the error that is now in the tests is because of an external issue. If you merge your branch with main, it should disappear.
Codecov Report
Attention: Patch coverage is 89.09370% with 71 lines in your changes missing coverage. Please review.
Project coverage is 96.01%. Comparing base (
9e3b342) to head (8bebfc1). Report is 325 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| satpy/readers/geos_netcdficare.py | 82.65% | 68 Missing :warning: |
| satpy/tests/reader_tests/test_geos_netcdficare.py | 98.84% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 96.06% 96.01% -0.05%
==========================================
Files 373 379 +6
Lines 54465 55813 +1348
==========================================
+ Hits 52321 53589 +1268
- Misses 2144 2224 +80
| Flag | Coverage Δ | |
|---|---|---|
| behaviourtests | 3.89% <0.00%> (-0.10%) |
:arrow_down: |
| unittests | 96.10% <89.09%> (-0.06%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.