satpy icon indicating copy to clipboard operation
satpy copied to clipboard

Add procedural solar_zenith_angle

Open mraspaud opened this issue 8 years ago • 4 comments

This PR is a proof on concept for procedural channels in satpy. Since original datasets are loaded before composites, have custom build composites for eg solar_zenith_angle would allow these composites to be generated if they are not provided in the dataset.

  • [ ] Closes #98
  • [ ] Tests added
  • [ ] Tests passed
  • [ ] Passes git diff origin/develop **/*py | flake8 --diff (remove if you did not edit any Python files)
  • [ ] Fully documented

mraspaud avatar Oct 16 '17 12:10 mraspaud

So what do we do with this PR ? Do we still want procedural channels ?

mraspaud avatar Apr 23 '18 12:04 mraspaud

I think this would be nice to have and I like what we have right now for the rayleigh corrector where the angles are optional and if not provided are created. The difference here would be that they can be created and shared between composites if they don't exist. Or even loaded by the user. This could be really helpful for testing new algorithms.

Once the compositor is created for these, it isn't super difficult to customize them for certain sensors (change the names of the dependent longitude/latitude dataset names). Biggest issue I see is getting this to work in those cases where there are multiple lon/lat datasets from the same reader. We have partially fixed this by being able to request resolutions in modifiers but for compositors we don't have anything that says "they requested SZA which doesn't exist and they want to use it with dataset X which is at this resolution...".

I'm not sure where to go from here.

djhoese avatar Apr 23 '18 12:04 djhoese

@mraspaud I'd like to move this to the v0.10 milestone. Thoughts?

This is a bit too large of a change and all of the necessary changes aren't really covered by this PR. Maybe a task for a future workshop?

djhoese avatar Jun 14 '18 12:06 djhoese

Sounds good, changing the milestone now

mraspaud avatar Jun 14 '18 13:06 mraspaud