momchil-flex

Results 178 comments of momchil-flex

Yeah the most straightforward fix which would also simplify the process (no need to upload/download various files) would be to add these things to `Simulation`. We've discussed that it's not...

> I suppose another short term option / fix could be to turn off caching if `"autograd" in simulation_type`? True that should work too and maybe can be done very...

By the way turning off caching `if "autograd" in simulation_type` has been implemented already last week, so the issue shouldn't be there right now, but we probably still want to...

> Will this resolve this issue? #1526 Yeah I reference it in my comment. It just needs to be done a bit more carefully and tested.

Ah you are right sorry! Updated it just in case someone clicks it in the future.

I haven't digested everything here but real quick comments: > However, another use case is an FDTD simulation, and you want to mode solve in just a planar region of...

@dmarek-flex had the suggestion that instead of tracking a submodule state, we can be tracking a submodule *branch*. I guess this would mean though that e.g. in pre/2.8 the corresponding...

Hm maybe this doesn't make that much sense after all. If I want to get back to some time in the past, I won't be able to check out the...

Now that I had another experience with this, I think what this PR is trying to do is a bit backwards to what we may want to happen. The most...

Yeah, I think that sounds good to me, let's see if others agree and we can hopefully fix this finally! :)