momchil-flex

Results 176 comments of momchil-flex

The biggest issue with reformatting the whole codebase is if it will make currently open PRs annoying to rebase. In principle it seems like it is not too bad, but...

I mean, it kinda sounds like we may keep our life simple if we either switch both already, or wait until after the backend poetry refactor. I don't really see...

Ok, yeah, let's do it after merging pre/2.7 to develop

After we merge 2.7 branches to develop - which I'm not opposed to doing soon. But it may be simpler to first merge the last remaining big things, adjoint, eme,...

> Also @yaugenst-flex some people use the scripts/test_local.sh which we probably need to decide it's future with this accordingly. Personally, I'd prefer if we all used the pre-commit Wait so...

I'm running backend tests just in case will merge tomorrow if all good https://github.com/flexcompute/tidy3d-core/actions/runs/9389775774

Hm yeah on the [backend](https://github.com/flexcompute/tidy3d-core/blob/develop/test_local.sh) it still just formats directly, I think we should remove the `--check`, any thoughts @yaugenst-flex @daquinteroflex ?

To chime in, it's highly unlikely that you actually need a CW source, unless you're doing nonlinear photonics and really need to control the total power in the simulation (make...

Yeah @QimingFlex in many cases we have to sacrifice defining things "rigorously" for the convenience of the user. In this particular case, and in general, only structures defined withing the...