momchil-flex
momchil-flex
Yeah, I agree with both of those suggestions. `Conformal` is commonly used. `Heuristic` is just something Victor had implemented a long time ago that we are keeping for backwards compatibility....
> One more question on names: is it necessary for each of them ending in`Subpixel`? `StaircasingSubpixel` and `ConformalSubpixel` sounds strange, because the two words in the former are contradictory; while...
I think maybe instead of a separate Geometry class this could be a Cylinder classmethod that creates a transformed cylinder?
The classmethod approach would also be easier for the backend, as in, no changes needed, vs. needing to implement an Ellipse there too otherwise. But at the end of the...
> > Thanks @marc-flex I think this is looking pretty good, just a few minor tweaks and also we should see if we want to apply this validator to all...
> > Just one comment: custom datasets are validated in `CustomMedium`. Shall we validate all other types of custom materials as well, e.g. CustomPoleResidue, CustomLorentz, etc.? > > You're opening...
Ok yeah sounds good to me.
Actually the latest test is fine now, it's the formatting test that fails. :) You need to run `bash scripts/test_local.sh` (and you can abort after the formatting step), or ```...
> > > Nice work! I tried a simple simulation > > > ``` > > > vertices = ((-1, -1), (0, -1 + 1e-10), (1, -1), (1,1), (-1, 1))...
I think this should be fine separately from the backend (we can migrate that to ruff too whenever we want) right @daquinteroflex? I mean, on the backend we only black...