momchil-flex

Results 204 comments of momchil-flex

> 2. Is a (x,y,z) in the data relative to the monitor center? or is it in global coordinates? I like global coordinates because the FieldData returned by solver is...

> I see your point about the centering of the monitor. I think I missed the bit about the center of the data being placed at the source center. I...

> Ok so allow only one `scalar_field.f` value and maybe just warn if it's outside of the `source.source_time.frequency_range`? Sounds reasonable to me. Yeah that sounds fine. > ========= > >...

Overall, sounds good. Note that I already reverted apply_symmetry in my normalization PR #455. I still need to make this work on the backend, I was waiting for us to...

> Yea that should be fine, it's just slightly weird that regular medium requires real permittivity and a real conductivity, but I guess the permittivity data comes back as complex...

> * Made `MonitorData.monitor` optional. In `SimulationData.apply_symmetry` added condition to just return a copy if monitor is `None` (no way to discretize). Maybe we should handle this differently, I tried...

I think what I had in mind about this is to add some explanation in the docs, and link to that explanation in the warning. Specifically, explain that frequency-domain monitors...

What I rather imagine is that the response is a list of supported versions. If the user version is not the latest, then print the warning suggesting an upgrade. If...

I pushed a commit rewording the messages a bit, and using `log.warning` instead of `print`. There are still a few things that need to be ironed out. I think it...

Could just print a warning "Could not verify version".