milo icon indicating copy to clipboard operation
milo copied to clipboard
verified publisher icon adobecom

MWPW-144756 Table - Responsive breakpoints - Text wraps under icon in Content cell

Open sivasadobe opened this issue 1 year ago • 10 comments

  • Changed the Icon and Text element as a flex box.
  • The content cell's text element will be wrapped inside the corresponding box
  • Icons & Text are vertically centered

Resolves: MWPW-144756

Test URLs:

CC

  • Before: https://main--milo--adobecom.hlx.live/drafts/siva/plans?martech=off
  • After: https://mwpw-144756--milo--sivasadobe.hlx.live/drafts/siva/plans?martech=off

Milo Table Doc

  • Before: https://main--milo--adobecom.hlx.live/docs/authoring/tables
  • After: https://mwpw-144756--milo--sivasadobe.hlx.live/docs/authoring/tables

sivasadobe avatar Apr 30 '24 06:04 sivasadobe

Page Scores Audits Google
/docs/authoring/tables PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/siva/plans?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

aem-code-sync[bot] avatar Apr 30 '24 06:04 aem-code-sync[bot]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions[bot] avatar May 01 '24 01:05 github-actions[bot]

@sivasadobe can you please check the alignment is not seen fine , in the feature branch appended

https://mwpw-144756--milo--sivasadobe.hlx.page/drafts/siva/plans?martech=off https://main--cc--adobecom.hlx.page/products/firefly/plans?milolibs=mwpw-144756--milo--sivasadobe image

CC : @sigadamvenkata

spadmasa avatar May 02 '24 05:05 spadmasa

@sivasadobe can you please check the alignment is not seen fine , in the feature branch appended

https://mwpw-144756--milo--sivasadobe.hlx.page/drafts/siva/plans?martech=off https://main--cc--adobecom.hlx.page/products/firefly/plans?milolibs=mwpw-144756--milo--sivasadobe image

CC : @sigadamvenkata

@spadmasa The texts are properly aligned now. Could you check again

sivasadobe avatar May 02 '24 05:05 sivasadobe

@sivasadobe i still see the same issue , please check image

spadmasa avatar May 03 '24 10:05 spadmasa

The second line of text is properly aligned beneath the text. https://main--cc--adobecom.hlx.page/products/firefly/plans?milolibs=mwpw-144756--milo--sivasadobe

Mobile View main--cc--adobecom hlx page_products_firefly_plans_milolibs=mwpw-144756--milo--sivasadobe

Desktop View Screenshot 2024-05-07 at 2 57 34 PM

cc @spadmasa

sivasadobe avatar May 07 '24 09:05 sivasadobe

Pushed code changes to support various icons, not just the :checkmark:

cc @spadmasa @Anupamasonnalagi

sivasadobe avatar May 07 '24 10:05 sivasadobe

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

github-actions[bot] avatar May 22 '24 01:05 github-actions[bot]

Validation done on the below url

https://main--cc--adobecom.hlx.page/products/firefly/plans?milolibs=mwpw-144756--milo--sivasadobe

image image image

Verified for other icons as well https://main--cc--adobecom.hlx.page/drafts/Souj/plans?milolibs=mwpw-144756--milo--sivasadobe&martech=off https://mwpw-144756--milo--sivasadobe.hlx.page/drafts/siva/plans?martech=off

spadmasa avatar May 23 '24 05:05 spadmasa

@sivasadobe it seems that the PSI check is failing - the automation process won't pick this PR up if the checks are not passing. see https://github.com/adobecom/milo/pull/2230#issuecomment-2087806049

mokimo avatar May 23 '24 07:05 mokimo