Mohamed Tarek

Results 405 comments of Mohamed Tarek

There are a few failed tests. These need to be isolated and reported upstream. Hessian tests also currently trigger a segfault on my machine so they are commented out. Overall...

Could you please add a test here for the intended use case?

>Do you have a minimal code example that reproduces them? Unfortunately no. I can dig into it next week if you don't beat me to it (please do :)).

Some of the internals here will be redesigned soon so I would wait for that to happen before trying to understand them :)

A package that only hosts types with no functions seems odd to me. For these types to be useful, they need to be passed to functions which specialise their behaviour...

>I'm just not sure on what time scale that can happen, so I thought a compatibility layer would be a useful first step. If the intention is there, it shouldn't...

I think most of the above action items are for the ADTypes maintainers.

It would be nice to open issues with specific examples where AD.jl introduces too much overhead or doesn't provide an API that's needed. I think I get the general idea...

I agree. Even Jacobians can be supported as long as either the inputs or outputs are real.

ya complex input and output is messy, let's stick to the simple cases