Mohamed Tarek

Results 405 comments of Mohamed Tarek

This issue is my fault. Feel free to remove the macro if it makes things simpler.

As I mentioned in https://github.com/JuliaDiff/AbstractDifferentiation.jl/issues/13#issuecomment-1994191014 and https://github.com/JuliaDiff/AbstractDifferentiation.jl/issues/123#issuecomment-1880412967, I am ok with removing the macro. It is currently a thin wrapper over a pushforward or pullback definition. Feel free to open...

@JuliaRegistrator register

Locally I tested on Enzyme main, still failed. CI will probably pull in 0.11.1. When 0.12 or 0.11.2 land, we can lower bound Enzyme here to the latest version that...

>Wouldn't it be more natural to make pushforward_function and pullback_function the primitives? Test it. If faster or more accurate, happy to switch.

Let me re-run the tests locally.

Tests still fail with the latest Enzyme on both M1 and Windows machines. Here is the Windows error. ```julia Status `C:\Users\moham\AppData\Local\Temp\jl_yH181v\Project.toml` [c29ec348] AbstractDifferentiation v0.6.0 `https://github.com/JuliaDiff/AbstractDifferentiation.jl.git#mt/enzyme` [d360d2e6] ChainRulesCore v1.16.0 [163ba53b] DiffResults...

Try running the test file locally after commenting out the lines for other backends.

I applied the comments and more tests pass now! A few still fail or error. The Hessian ones crash Julia so I commented them out.