AbstractDifferentiation.jl icon indicating copy to clipboard operation
AbstractDifferentiation.jl copied to clipboard

Yota support

Open mohdibntarek opened this issue 3 years ago • 5 comments

This PR is based on #49 but tests here fail. I am opening it in case @dfdx or someone else can figure out why they fail when Zygote passes.

mohdibntarek avatar Feb 08 '22 00:02 mohdibntarek

I see one error coming from a Yota bug that is already fixed on main, but I can't immediately understand the others, especially related to the arity of functions, e.g.:

MethodError: no method matching fder(::Float64) Closest candidates are: fder(::Any, ::Any) at /home/runner/work/AbstractDifferentiation.jl/AbstractDifferentiation.jl/test/test_utils.jl:6

Do you have a minimal code example that reproduces them? If not, give me a couple of days to learn internals of AbstractDifferentiation and find where the problem comes from.

dfdx avatar Feb 08 '22 22:02 dfdx

Codecov Report

Merging #50 (89ed1b8) into master (8f0d6db) will decrease coverage by 5.15%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   83.36%   78.21%   -5.16%     
==========================================
  Files           6        6              
  Lines         475      358     -117     
==========================================
- Hits          396      280     -116     
+ Misses         79       78       -1     
Impacted Files Coverage Δ
src/AbstractDifferentiation.jl 77.41% <0.00%> (-1.00%) :arrow_down:
src/ruleconfig.jl 0.00% <0.00%> (-100.00%) :arrow_down:
src/finitedifferences.jl 75.00% <0.00%> (-25.00%) :arrow_down:
src/tracker.jl 83.33% <0.00%> (-16.67%) :arrow_down:
src/forwarddiff.jl 86.20% <0.00%> (-13.80%) :arrow_down:
src/reversediff.jl 92.00% <0.00%> (-8.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f0d6db...89ed1b8. Read the comment docs.

codecov-commenter avatar Feb 09 '22 00:02 codecov-commenter

Do you have a minimal code example that reproduces them?

Unfortunately no. I can dig into it next week if you don't beat me to it (please do :)).

mohdibntarek avatar Feb 09 '22 02:02 mohdibntarek

I managed to fix a few cases, but the amount of errors only grows, and I don't understand the code base here well enough to understand what exactly is expected. Is there a minimal set of interfaces that need to be implemented? Perhaps, value_and_xxx set of methods?

dfdx avatar Feb 22 '22 21:02 dfdx

Some of the internals here will be redesigned soon so I would wait for that to happen before trying to understand them :)

mohdibntarek avatar Feb 23 '22 02:02 mohdibntarek