Mohamed Tarek
Mohamed Tarek
Sounds good, happy to merge PRs but unlikely to do it myself soon.
Exposing different batching strategies is interesting. Perhaps we can just provide utility functions to calculate the batch size to be passed to the `batch_size` kwarg. This will require minimal changes...
If you put an "up for grabs" tag on these issues, I can work on fixing them in my free time. I have interest in getting this package registered as...
Thanks for that. I will do what I can.
For lightweight tasks it seems that even a small batch size is doing very well. In my tests, a batch size of 1 was doing relatively well only
It's the code in these tests. You can try using different `batch_size = ...` keyword arguments and check the timings. https://github.com/bkamins/KissThreading.jl/blob/947961c17854275d5658c8b60bb44cc160e7a858/test/bootstrap.jl#L7 https://github.com/bkamins/KissThreading.jl/blob/947961c17854275d5658c8b60bb44cc160e7a858/test/bubblesort.jl#L8 https://github.com/bkamins/KissThreading.jl/blob/947961c17854275d5658c8b60bb44cc160e7a858/test/sort_batch.jl#L7
@UserQuestions please note that KissThreading should be supporting Julia v0.6 now.
I had it on Windows.
Yes `tforeach` is nicer.
I am ok with merging them :)