AbstractDifferentiation.jl icon indicating copy to clipboard operation
AbstractDifferentiation.jl copied to clipboard

Support complex pullbacks

Open sethaxen opened this issue 4 years ago • 4 comments

Replaces _dot with _realdot, which allows for pulling back through functions with complex outputs. Resolves #22. This is currently untested.

sethaxen avatar Oct 12 '21 19:10 sethaxen

Codecov Report

Merging #23 (9bab121) into master (b4343f5) will decrease coverage by 1.15%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   78.26%   77.10%   -1.16%     
==========================================
  Files           1        1              
  Lines         345      345              
==========================================
- Hits          270      266       -4     
- Misses         75       79       +4     
Impacted Files Coverage Δ
src/AbstractDifferentiation.jl 77.10% <16.66%> (-1.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4343f5...9bab121. Read the comment docs.

codecov-commenter avatar Oct 12 '21 19:10 codecov-commenter

Could you please add a test here for the intended use case?

mohdibntarek avatar Nov 02 '21 07:11 mohdibntarek

Certainly, though the tests need a few refactors first to make testing these cases more straightforward. Some changes made in #27. More will be necessary.

sethaxen avatar Jan 09 '22 13:01 sethaxen

Also, this PR should use RealDot.jl now that it exists.

sethaxen avatar Jan 09 '22 13:01 sethaxen