Michel Loiseleur comments

Results 543 comments of


                                            Michel Loiseleur

Do not expose the AWS role external id in the logs

/lgtm

Do not expose the AWS role external id in the logs

/lgtm /assign @szuecs /unassign @mloiseleur

adds soft error for google provider

@EWK20 thanks for this PR. Would you please update tests accordingly ?

adds soft error for google provider

See other PR like https://github.com/kubernetes-sigs/external-dns/pull/4437, for instance.

adds soft error for google provider

/lgtm

Added the scorecard github action and its badge

/lgtm /assign @Raffo for final review

feat: NAT64 network source

It's very interesting, thanks :+1:. For the documentation, there is a source tab, see [here](https://kubernetes-sigs.github.io/external-dns/v0.14.2/sources/sources/). Wdyt of adding a new doc in this section ? /ok-to-test

feat: NAT64 network source

/retitle feat: NAT64 network source /lgtm

feat: Become IDNA aware in Plan and DomainFilter

Thanks for this PR @kimsondrup ! Reviewing the tests with all those emojis in FQDN are really fun :) /ok-to-test

feat: Become IDNA aware in Plan and DomainFilter

> It is less cut and dry since `txtPrefix` and `txtSuffix` might conflict with how Ponycode prefix each level of the domain with `xn--` and again suffix each level with...