external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

feat: NAT64 network source

Open johannwagner opened this issue 1 year ago • 10 comments

Description

We run an IPv6 only Kubernetes cluster environment and designated a /96 IPv6 network to map to an IPv4 address space in a casual NAT64 setup. Therefore, we need to create an A record for each AAAA record within this address room.

We added an additional source wrapper, similar to DedupSource and added a config value for the NAT64 prefixes. The source wrapper looks at all AAAA records and translates them - if applicable - into A records. We also added unit tests for that.

Note: I did not add any enduser documentation, because I was not sure where to put this part specifically. If you can give me a pointer, I would be happy to add this.

Checklist

  • [x] Unit tests updated
  • [x] End user documentation updated

johannwagner avatar Jul 05 '24 06:07 johannwagner

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: johannwagner / name: Johann Wagner (b8e018caaf2046c2dc8e3f5596f98989b2cc92ba, 1b4843aa0256c99ebb01dbb22d02deb37ce2e70f)

Welcome @johannwagner!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 05 '24 06:07 k8s-ci-robot

Hi @johannwagner. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 05 '24 06:07 k8s-ci-robot

/easycla

johannwagner avatar Jul 05 '24 06:07 johannwagner

It's very interesting, thanks :+1:. For the documentation, there is a source tab, see here. Wdyt of adding a new doc in this section ? /ok-to-test

mloiseleur avatar Aug 09 '24 09:08 mloiseleur

Thanks!

I will add docs on Monday, currently on vacation. 🙌

johannwagner avatar Aug 09 '24 10:08 johannwagner

Since it is not really a source-based addition and should work for all sources, I would rather put it in the Advanced Topic section after some consideration.

johannwagner avatar Aug 09 '24 14:08 johannwagner

Added some documentation, I also tried to give a usage example but it's very networky and probably a niece topic anyways.

johannwagner avatar Aug 12 '24 16:08 johannwagner

/retitle feat: NAT64 network source /lgtm

mloiseleur avatar Aug 19 '24 06:08 mloiseleur

/approve

szuecs avatar Sep 05 '24 13:09 szuecs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 05 '24 13:09 k8s-ci-robot