Michel Loiseleur
Michel Loiseleur
@arthlr If you rebase this PR on top of #5514, it should fix the failing ci test.
@arthlr We will make a new release next week. If you can address the last review comments, then maybe this PR can be merged before we release.
This PR looks technically ok. You need to update Changelog, too. Chart maintainer will decide if we should support this feature. /assign @stevehipwell
@youkoulayley @jspdown Wdyt of also avoiding building binaries, run unit test and validate on doc PR, using the same `path-ignore` trick ?
> Why not avoiding building binaries, running unit test but we can't skip validate because the `validate` target is validating the documentation. Gotcha. I updated my PR accordingly.
> We also need to be sure to block merging PR if one checks is failing. I'm not sure how to do it with current feature set on github actions.
> We also need to be sure to block merging PR if one checks is failing. It's not clear, but maybe there [is a way](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks) with a script, see [this...
@mmatur: :thinking: I'm not sure to folllow you. If we do not use _conditional_ trick with current branch protection and we do not switch to ruleset, how can we be...
/ok-to-test