Michel Loiseleur

Results 558 comments of Michel Loiseleur

/retitle feat(txt-registry): add support for TXT records

`getSupportedType` is still called in #3774 I agree with you, it should be reworked after #3774 is merged. /hold

@starcraft66 Thanks for the documentation. See my comments for a first review of the code.

It seems we can proceed with final review and merge for this one. @starcraft66 Do you think you can address the last comments and rebase this PR ?

@starcraft66 Do you think you can address review comments ?

/ok-to-test /assign @abursavich for a first review

@daegalus @nichcuta @davidspek Following @ivankatliarchuk and my review, this PR won't be merged "as is". The use case is ok, the current approach / implementation is not. Feel free to:...

@davidspek: The PR to fix the race condition has been merged. > Other than that, how does the new implementation look? It looks way better to me. @davidspek: Has it...

I understand your needs. I'm not sure of the correct way to fix it and it seems a really specific needs. The tpl has been introduced last year with https://github.com/traefik/traefik-helm-chart/pull/972...