external-dns icon indicating copy to clipboard operation
external-dns copied to clipboard

adds soft error for google provider

Open EWK20 opened this issue 1 year ago • 7 comments

Add soft errors to google provider where it is possible to retry or recover.

Description

Leverages #4166 by adding soft errors to the google provider

Checklist

  • [ ] Unit tests updated
  • [ ] End user documentation updated

EWK20 avatar Aug 15 '24 12:08 EWK20

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: EWK20 (920e6820beb16c512a58a0c84d334f1169c86268, 3f73f86da044fbcd58f140e5c459cc3c6b030ad4)

Welcome @EWK20!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 15 '24 12:08 k8s-ci-robot

Hi @EWK20. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 15 '24 12:08 k8s-ci-robot

@EWK20 thanks for this PR. Would you please update tests accordingly ?

mloiseleur avatar Aug 16 '24 09:08 mloiseleur

Hi @mloiseleur, can you please highlight how i should update the tests? I had a look through the test file and saw that there are no tests that check the error returned. Thank you

EWK20 avatar Aug 27 '24 11:08 EWK20

See other PR like https://github.com/kubernetes-sigs/external-dns/pull/4437, for instance.

mloiseleur avatar Aug 27 '24 12:08 mloiseleur

/ok-to-test

szuecs avatar Sep 18 '24 19:09 szuecs

/approve

szuecs avatar Sep 18 '24 19:09 szuecs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 18 '24 19:09 k8s-ci-robot

/lgtm

mloiseleur avatar Sep 19 '24 09:09 mloiseleur