Mike Lin

Results 150 comments of Mike Lin

@jdidion Thanks, for downloads this would be a straightforward modification to the [downloader code here](https://github.com/chanzuckerberg/miniwdl/blob/f0691200527c8a782ba8283f468d13f057744cbc/WDL/runtime/download.py#L202-L205). 1. The way it asks which docker image to use for AWS CLI provides an...

@morsecodist I haven't yet figured out the exact problem, but here's some context for those changes that might help us zero in. * First, it's better to pretend the two...

@rhpvorderman Apologies for the long delay picking up on this, been moving house and other interruptions. On first reading, two comments on the code 1. The search for directory component...

@rhpvorderman Sure, the current `out/` directory structure is meant to be programmatically navigable (so that a script that doesn't have or want to parse outputs.json can still navigate the WDL...

Should one now use an intermediate variable every time for this pattern? Seems like inconveniencing a really common case to catch a rare one.. The following two variations seem to...

Hi Pyre team! I've been sticking on v0.0.28 for the last few months because it didn't seem reasonable to me to have to go through [my codebase](https://github.com/chanzuckerberg/miniwdl) and replace many...

Thanks @grievejia! The `Final[]` annotation looks like just the right solution. I also noted @shannonzhu mentioning the upcoming [walrus operator](https://www.geeksforgeeks.org/walrus-operator-in-python-3-8/) on the related https://github.com/facebook/pyre-check/issues/221#issuecomment-566176602 -- this would make the intermediate...

@lh3 @hasindu2008 Promoting this out of draft now that we (mainly @rzlim08) have built up some experience using the proposed distributed mapping for our metagenomics use case (where the reference...

@hasindu2008 I think we were exploring comparable numbers of partitions but @rzlim08 can confirm. I assume the preset thresholds (for short reads) of mid_occ and max_occ are tuned to minimize...

Should we just explicate that/whether expression placeholders work inside multi-line strings?