Michael Carroll

Results 311 comments of Michael Carroll

Just a note that with the bazel implementation, I added a `--root-dir` flag that allows all includes to be resolved relative to that directory. The way that this works for...

Just a note that these changes are ABI-breaking (adding members and changing inheritance), so definitely need to land in rolling.

There isn't enough information to reproduce here, and the issue is quite dated at this point. Based on my reading, it would look like `rcl_action` is missing, which would indicate...

The current implementation was written against OptiX 3.8 (https://github.com/gazebosim/gz-rendering/blob/gz-rendering8/CMakeLists.txt#L183-L185) so it is likely substantially outdated and would need a good bit of work to bring up to date. I don't...

We discussed this in the triage meeting yesterday. The suggested solution would be to add a way to pass a `TimeSource` via the `NodeOptions` to allow users to override the...

I think since we are C++17, there isn't anything blocking this from a compiler perspective. As you mention, we make pretty heavy use of null-terminated strings in the RCL and...

@oysstu is this something that would be potentially interested in prototyping so we could come up with concrete recommendations and identify any issues as @clalancette mentions?

Seems like a reasonable improvement. I'm adding this to the upcoming ROS 2 PMC meeting agenda.

I fall somewhere in the middle on this one. While I wouldn't go so far as to call it a design flaw, I think relying on the order that the...

Would it additionally make sense to introduce a CI job to make sure that this docker file can build on, for instance, a nightly basis?