Michael Carroll
Michael Carroll
So for `gz-cmake3`, I think the thing that drives CMake version the most are: * Ubuntu Focal (CMake 3.16.3-1ubuntu1) * Ubuntu Jammy (3.22.1-1ubuntu1) We should probably update the logic to...
> having worked with some of the find_package(Python3) logic, I think we should just deprecate GzPython I'm always in favor of less code!
Just a note that `cmake_path` can be used for path manipulation in 3.20+ and may tidy up code: https://cmake.org/cmake/help/latest/command/cmake_path.html
> I took a look at this, can we just remove the FindGzProtobuf.cmake entirely? I think that it probably makes sense. I noticed recently that our implementation misses some of...
An example implementation in ign-common: https://github.com/ignitionrobotics/ign-common/pull/300
Signal handling and propagation on Windows is incredibly dumb. I honestly think finishing up standalone executables is the better approach.
I think that tiny_process_library also uses `ProcessTerminate`, which is the equivalent of `sigkill` on Windows. That will certainly stop the process, but it's not necessarily a clean way of doing...
> I would like to create a gif like the other tutorial. Can the maintainers recommend a process to do that? Or, is it OK to do the tutorial without...
> Also the commit changes seem a bit messy, I was using clang format with the Google C++ Style guide as configuration, which leaded to the changed formatting that you...
[Holding for Iron sync](https://discourse.ros.org/t/preparing-for-iron-sync-2024-09-06/) If you want these in faster, it's better to separate them. Otherwise we will wait until there are no sync holds for the impacted distros.