[easy] remove dead code

[mimoo]

it seems like we were using these functions (ToBytes, FromBytes) and traits (num-derive) before we moved to serde for serialization. So removing this code now.

[github-actions[bot]]

Hello there👋 Here are some benchmark results using criterion. Keep in mind that since this runs in CI, it is not really accurate (as it depends on the host load)

   Compiling kimchi v0.1.0 (/home/runner/work/proof-systems/proof-systems/kimchi)
    Finished bench [optimized] target(s) in 34.52s
Gnuplot not found, using plotters backend
Benchmarking Proof creation/proof creation (2^15)
Benchmarking Proof creation/proof creation (2^15): Warming up for 3.0000 s

Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 79.0s.
Benchmarking Proof creation/proof creation (2^15): Collecting 10 samples in estimated 79.010 s (10 iterations)
Benchmarking Proof creation/proof creation (2^15): Analyzing
Proof creation/proof creation (2^15)
                        time:   [7.8332 s 7.8382 s 7.8430 s]

Benchmarking Proof verification/proof verification
Benchmarking Proof verification/proof verification: Warming up for 3.0000 s
Benchmarking Proof verification/proof verification: Collecting 10 samples in estimated 7.4405 s (30 iterations)
Benchmarking Proof verification/proof verification: Analyzing
Proof verification/proof verification
                        time:   [247.90 ms 248.09 ms 248.31 ms]

Here's some more accurate benchmark with iai

bench_proof_creation
  Instructions:        362168766681
  L1 Accesses:         444158861987
  L2 Accesses:            274250975
  RAM Accesses:           272567908
  Estimated Cycles:    455069993642

bench_proof_creation_and_verification
  Instructions:        364994514065
  L1 Accesses:         447650424234
  L2 Accesses:            277207423
  RAM Accesses:           272970988
  Estimated Cycles:    458590445929

[mrmr1993]

Can you make a corresponding mina PR, to confirm that this code is dead?

[mimoo]

will do after I can get the double generic gate in

[github-actions[bot]]

Stale pull request message

[github-actions[bot]]

Stale pull request message

[github-actions[bot]]

Stale pull request message

[joseandro]

@mimoo what's the latest on this?

[mimoo]

keeping it around until I have time to do it. BTW we already have a bot checking on stale PRs/issues ;)

[github-actions[bot]]

Stale pull request message

[github-actions[bot]]

Stale pull request message