David Wong
David Wong
I guess there are 4 cases, maybe a match statement would make sense: ```rust match (index_has_lookup, lookup_commitment_field_set) { (x, y) if x == y => () (x, y) => error...
yeah no worries! If you ever think of a list of things that were hard to grasp to tackle the first one I can try to make these clearer for...
if you can find them yourself it's good, otherwise I can list more when you have a PR : )
I still think we should also use the iter trick for the arrays (w, coefficients, and s) so we're not doing an off by one or something :o
awesome! Let's close this one now :) thanks!
thanks a lot for the fix :)
keeping it around until I have time to do it. BTW we already have a bot checking on stale PRs/issues ;)
@mrmr1993 we should move that to the mina book, I can do this if you don't wanna do it?
cc @jspada @querolita do you think this should get in before the hardfork?
I think that's fine, but in general this tool seeks to be language agnostic so I don't think it makes sense to have the main binary be a cargo tool...