David Wong comments

Results 393 comments of


                                            David Wong

rename CellVar to FieldVar?

another thing that we really need to emphasize, is how we have backend vars (`FieldVar`), and circuit vars (`Var`). Where circuit vars are basically array of field vars.

New cipher and hashes

Thanks! No plans really, as this is supposed to be a biased implementation of Noise that you can use without configuration. I can see the case for AES-GCM If all...

New cipher and hashes

I see. I still think it’s a good idea to support aes-gcm as long as there is a biased default configuration that uses one of them (that you should be...

can we get rid of the `const` keyword?

in my notes I had "replace `const Field` with `Number` or `Int` or smthg"

&&, ||, ! versus and, or, not

but this would be a departure from system languages, which we are trying to mirror here...

return early if proof malformed

I'll copy what I wrote in https://github.com/o1-labs/proof-systems/issues/751#issuecomment-1430160113 : So an update on the issue, which I think still misses a number of things: * there's more than the evaluation lengths...

ConstraintSystem and ProverIndex

yeah, and that `Circuit` type can disappear after (because it has the same fields `ConstraintSystem` has)

ConstraintSystem and ProverIndex

currently I think that these are the fields that should be moved to the prover index: ```rust pub struct ConstraintSystem { // good pub public: usize, // mmmm, that sounds...

max_poly_size and max_quot_size

thanks again!

confusing error involving `.cmi` and `<here>`

Thanks! I guessed as much but thought this was still vague enough that it was worthy of an issue o.o Perhaps it should talk about `foo.ml(i)` if it knows for...