David Wong
David Wong
ping @mrmr1993
The joy of git submodules
I really need to figure out what's a one-liner git command to revert all the git submodules back to their versions in develop. Should be good now, cc @mitschabaude
ping @mrmr1993 @imeckler
`opam pin add lib https://github.com/mimoo/lib` also takes a URL without the `git+`
honestly, I wrote this such a long time ago that I don't know. But it used to work so I wouldn't change things around :)
I thought I had answered this but apparently not, the point is that it doesn't really seem related to the SRS which should be a "commitment"-focused data structure (https://o1-labs.github.io/proof-systems/specs/urs.html). Semantically...
truer today than ever :D I think we will need to look into simplifying that part at some point. The problem now is all the generics: ```rust pub struct PointEvaluations...
thanks @duguorong009 !
the code is different because it must have been updated since I wrote this issue :) I still see the sorted commitments absorbed here: * [prover](https://github.com/o1-labs/proof-systems/blob/f353a04848363374b8318cb96224370b1105e085/kimchi/src/prover.rs#L497) * [verifier](https://github.com/o1-labs/proof-systems/blob/f353a04848363374b8318cb96224370b1105e085/kimchi/src/verifier.rs#L116) my issue...