David Wong
David Wong
so some comments: * yeah you will need to use `serde_as` on your `ChunkedEvaluations` type to implement serde serialize/deserialize. You can see how this is done on all the types...
eventually the other structures should be generic based on a type of `Field`, not a `Vec`. For example: ```rust pub struct ProofEvaluations { /// witness polynomials pub w: [ChunkedEvaluations; COLUMNS],...
basically something that looks like this: ```rust Thing2 { a: F, } Thing { thing2: Thing2 ``` should change to something that looks like this: ```rust Thing2 { a: Vec,...
had a pass at it and it looks good to me
you could create a dummy function for the new type as well
btw @duguorong009 don't hesitate to let me know if you're stuck on something and need help : ) I think you had a good PR!
1. dummy is most likely something like a `default()` function, and should be used in tests. (It'd be nice if these kind of things were gated behind a `#[cfg(test)]`) 2....
playing with it here: https://github.com/MinaProtocol/mina/pull/11906 it seems to compile the stubs. Not sure if mina compiles yet, and haven't touched the wasm part.
ah dang :( can't have the best of both world, thanks though!
That's what I recommend in [nixbyexample](https://mimoo.github.io/nixbyexample/flakes-flake-utils.html), but I'm surprised you need to reach out for a third dep to do this