Michael Solomon

Results 282 comments of Michael Solomon

@piotrm221 Thanks! :) There are some things to do in both `nock` and `mswjs/interceptors`. I hope we can merge this in January.

![image](https://github.com/nock/nock/assets/11459632/8d6675cf-a3c5-466e-9a3a-8855c13cf7e5)

This is working with version 20: ![image](https://github.com/nock/nock/assets/11459632/88177aad-3fce-44f7-a91a-51cc6814d75b) And v19.9.0. Feel free to reopen if needed.

@gr2m This is because we ignore the interceptor's headers: https://github.com/nock/nock/blob/f4d1b15d8ef64ae6d8c0e6d7c62324a19f138b5f/lib/interceptor.js#L68-L74 What's the expected behavior? Should we merge the headers? Do the interceptor's headers take precedence? vice-versa? P.S: @josephearl I think...

Potential duplication: https://github.com/nock/nock/issues/2353

Thanks @bartoszhernas! Would you mind creating a pull request and adding a test?

Maybe we can merge this for the `beta` instead.

@bkendall If you are referring to the `fetch` API, please see this URL: https://github.com/nock/nock/pull/2602.

Now the beta supports this case :) This is closed in favor of #2760, which adds the tests.