Michael Solomon

Results 282 comments of Michael Solomon

I think we need to work on the `beta` channel instead of the main (I hope to merge it soon). We can backport it if needed.

I think we should extract the signal abort from the `handleRequest` method and send it to the outer interceptor because each client behaves differently. From a quick check: 1. Fetch...

@kettanaito > I receive the file's content decoded. I don't do the compression though. What do you mean? You do compress the response in the server

@kettanaito I added an unmocked test which passes.

@kettanaito I think we should check the environment, and if running in Node.js, use `zlib`, otherwise use a browser-compatible library. WDYT?

@kettanaito I see. I see it is a bit hacky, but what about a different `tsconfig` with [path alias](https://www.typescriptlang.org/tsconfig/#paths)? I like this approach because it may solve other environment-specific code...

@kettanaito LGTM Just curious about `PipelineStream`. I'm not sure why we need this. Thanks for working on this!

Ohh Ok! I see.. Not sure if I'd stick with Web API here (DecompressionStream) because AFAIU this code is used only by Node.js, but the current implementation is great too.

@kettanaito I think there is something with the decompression order.. still looking to understand the root cause (if any)