Michael Solomon

Results 282 comments of Michael Solomon

@gr2m I came up with a more practical solution that lets us do things more gradually. I'm trying to implement this now. At first, we need to add the missing...

Thanks @kettanaito! > My initial thought was that you can... This was mine, too. Unfortunately, it seems like the mocking parts and the "nock-related" features code are jumbled in hard-to-separate...

@kettanaito Thanks for the insights and details! I ended up doing something very similar, and it's working (woohoo). https://github.com/nock/nock/pull/2517 WDYT? PS: for some reason, `got` gets stuck, but `fetch` and...

It seems like `nock` function should specifiy only the [`hostname`](https://github.com/nock/nock?tab=readme-ov-file#specifying-hostname) and not the whole [path](https://github.com/nock/nock?tab=readme-ov-file#specifying-path). e.g. this is working: ```js it.only('post with another regexp as spec', async () => {...

@jaridmargolin IIUC and according to the types, responses must be either a `string` or an `object`. Maybe the problem is in the recorder, which saves value as a boolean?

@kettanaito Until we resolve the `got` problem, I workaround the problem in my local machine and work on fixing the failing test 💪 Maybe you have an idea of how...

@kettanaito The test fails with `Uncaught Error`, I'd expect `msw` to catch the error and emit an `error` event, which later gets caught by the listener in the test ![image](https://github.com/nock/nock/assets/11459632/7d5a5e09-83f3-4bcb-b61c-b4e056f1e0b7)

![image](https://github.com/nock/nock/assets/11459632/134425fa-ff96-4928-a2c1-a8117fe10c55) `test_intercept` almost done! Most of the failures have a PR in `@msw/interceptors` repo, but a couple still need to be reviewed and addressed. We will handle them soon. :)...

We are making progress and moving forward! ![image](https://github.com/nock/nock/assets/11459632/79604328-db36-47a5-ae8f-a7166a6fa34a)

💪 ![image](https://github.com/nock/nock/assets/11459632/61172e79-812d-4f93-93a2-93f9c75afdd4)