Michael Solomon

Results 282 comments of Michael Solomon

@kettanaito Thank you for your willingness to help and I apologize for any clutter I may cause! With your assistance, we can support both the 'nock' and 'msw' approaches to...

@gr2m Why does Nock expose the request object via the response ("res.req") https://github.com/nock/nock/blob/main/tests/test_define.js#L232 This is not part of the `IncomingMessage` object API.

@gr2m Also, we currently pass the `rawHeaders` as-is. according to the [docs](https://nodejs.org/api/http.html#messagerawheaders), the rawHeaders is string of array. [While we support arrays, objects, and maps](https://github.com/nock/nock/blob/feaa66fa64d24f95937ef759cdd5a7ca07646f1c/lib/common.js#L250) in the `reply` function, we...

@kettanaito I see. Nock exposes this (unofficially, I think) to the end user, and we even have a test for it ('has a req property on the response"). So I'm...

> If I recall correctly, that was a hack to make intercepting requests work @gr2m So if `msw/interceptors` does the interception, Can we safely remove it? > I would consider...

@gr2m I completely agree. The test suite is crucial to ensuring the success of this project. I am making an effort to avoid making any changes to the tests unless...

![image](https://github.com/nock/nock/assets/11459632/cb57e4e9-ae68-43d2-88f4-77de24fe87b5)

Each pending test has a `TODO` indicating what needs to be done for them to pass. ![image](https://github.com/nock/nock/assets/11459632/2e9e4ee6-e66f-4551-9f04-070c62907629) @kettanaito sorry for all the issues I opened in the last week 😅...

Hey guys, Due to the situation in Israel, I have limited time to invest in this. However, I will continue our efforts whenever possible (like this weekend :)). Hopefully, we...

😁 ![image](https://github.com/nock/nock/assets/11459632/c2e49fb0-f837-42d1-a3b7-b5d7879c8155)