Michele Esposito comments

Results 26 comments of


                                            Michele Esposito

Add data type for property `encryptor`

@gantunesr can this be considered closed by https://github.com/MetaMask/KeyringController/pull/293?

chore(deps): bump accounts-controller to ^14.0.0

@metamaskbot update-policies

chore(deps): Bump notification-controller to ^5.0.1

@metamaskbot update-policies

[phishing-controller] Add `PhishingDetector` from `eth-phishing-detector`

Main files from `eth-phishing-detector` original package have been added in this commit 1775471f86163696226976dbbaf6c8dace6d0dfc for an easier diff

[phishing-controller] Add `PhishingDetector` from `eth-phishing-detector`

@NicholasEllul exactly! the plan is to leave the `eth-phishing-detect` package for the configuration only. We'll remove the PhishingDetector implementation from that package once we have it here

fix: hd keyring logic in addNewAccountForKeyring

Unrelated to this PR: I think that this method will probably need more refactoring or to be removed completely, since the current behaviour does not make much sense We allow...