metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard

Published 20 hours ago • verified publisher icon MetaMask

chore(deps): bump accounts-controller to ^14.0.0

Open montelaidev opened this issue 10 months ago • 18 comments

Description

This PR bumps the AccountsController to 14.0.0, @metamask/keyring-api to ^6.0.0 and @metamask/eth-snap-keyring to ^4.0.0

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

  • [x] I’ve followed MetaMask Coding Standards.
  • [x] I've completed the PR template to the best of my ability
  • [x] I’ve included tests if applicable
  • [x] I’ve documented my code using JSDoc format if applicable
  • [x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

montelaidev avatar Apr 19 '24 14:04 montelaidev

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Apr 19 '24 14:04 github-actions[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network +6 946 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Apr 19 '24 14:04 socket-security[bot]

@metamaskbot update-policies

montelaidev avatar Apr 23 '24 08:04 montelaidev

Policy update failed. You can review the logs or retry the policy update here

metamaskbot avatar Apr 23 '24 08:04 metamaskbot

@metamaskbot update-policies

montelaidev avatar May 07 '24 10:05 montelaidev

Policies updated

metamaskbot avatar May 07 '24 10:05 metamaskbot

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar May 07 '24 10:05 socket-security[bot]

Builds ready [dd4fa28]
Page Load Metrics (1028 ± 636 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint59162942613
domContentLoaded8361584
load47344610281325636
domInteractive8361584
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 26.71 KiB (0.76%)
  • ui: -15 Bytes (-0.00%)
  • common: 1019 Bytes (0.02%)

metamaskbot avatar May 07 '24 16:05 metamaskbot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.71%. Comparing base (cf417bb) to head (98434c9).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #24130      +/-   ##
===========================================
+ Coverage    65.70%   65.71%   +0.01%     
===========================================
  Files         1366     1368       +2     
  Lines        54364    54385      +21     
  Branches     14142    14150       +8     
===========================================
+ Hits         35715    35736      +21     
  Misses       18649    18649

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 16:05 codecov[bot]

@metamaskbot update-policies

montelaidev avatar May 21 '24 15:05 montelaidev

Policies updated

metamaskbot avatar May 21 '24 15:05 metamaskbot

Builds ready [a46bca7]
Page Load Metrics (1654 ± 567 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722241154019
domContentLoaded10391784
load58304216541182567
domInteractive10391784
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -20.36 KiB (-0.60%)
  • ui: 0 Bytes (0.00%)
  • common: 692 Bytes (0.01%)

metamaskbot avatar May 21 '24 16:05 metamaskbot

@metamaskbot update-policies

mikesposito avatar May 23 '24 13:05 mikesposito

Policies updated

metamaskbot avatar May 23 '24 13:05 metamaskbot

@metamaskbot update-policies

montelaidev avatar May 24 '24 06:05 montelaidev

Policies updated

metamaskbot avatar May 24 '24 06:05 metamaskbot

Builds ready [b360c84]
Page Load Metrics (875 ± 527 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60138952110
domContentLoaded94617115
load4825558751098527
domInteractive94617115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -20.36 KiB (-0.58%)
  • ui: 0 Bytes (0.00%)
  • common: 692 Bytes (0.01%)

metamaskbot avatar May 24 '24 07:05 metamaskbot

Builds ready [8858dd5]
Page Load Metrics (1656 ± 630 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint601761102612
domContentLoaded95717115
load48349016561311630
domInteractive95717115
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -20.36 KiB (-0.58%)
  • ui: 0 Bytes (0.00%)
  • common: 692 Bytes (0.01%)

metamaskbot avatar May 24 '24 07:05 metamaskbot

Builds ready [ce61148]
Page Load Metrics (426 ± 400 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6615194199
domContentLoaded9471484
load552413426833400
domInteractive9471484
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -20.36 KiB (-0.58%)
  • ui: 0 Bytes (0.00%)
  • common: 692 Bytes (0.01%)

metamaskbot avatar May 27 '24 11:05 metamaskbot

@metamaskbot update-policies

montelaidev avatar May 28 '24 09:05 montelaidev

Policies updated

metamaskbot avatar May 28 '24 09:05 metamaskbot

The new line added in the privacy snapshot is coming from here when i run the test locally.

<testsuite name="Snap Account Signatures" timestamp="2024-05-30T07:18:47" tests="3" file="/Users/montelai/consensys/extension-2/test/e2e/accounts/snap-account-signatures.spec.ts" time="31.928" failures="3">
    <testcase name="Snap Account Signatures can sign with sync flow" time="31.290" classname="can sign with sync flow">
 <failure message="A new host not contained in the privacy-snapshot received a network
           request during test execution. Please update the privacy-snapshot
           file by passing the --update-privacy-snapshot option to the test
           command or add the new hosts to the snapshot manually.

           New hosts found: api.web3modal.org." type="Error"><![CDATA[Error: A new host not contained in the privacy-snapshot received a network
           request during test execution. Please update the privacy-snapshot
           file by passing the --update-privacy-snapshot option to the test
           command or add the new hosts to the snapshot manually.

           New hosts found: api.web3modal.org.
           ```

montelaidev avatar May 30 '24 08:05 montelaidev

Removing api.web3modal.org from the privacy-snapshot.json. This was added because of a timezone issue when run locally.

https://github.com/WalletConnect/web3modal/blob/712252de35446c10bb9413bf85ec5f2937dbd44c/packages/core/src/utils/CoreHelperUtil.ts#L188-L204

getApiUrl() {
    return CoreHelperUtil.isRestrictedRegion()
      ? 'https://api.web3modal.org/'
      : 'https://api.web3modal.com/'
  },

https://github.com/WalletConnect/web3modal/blob/712252de35446c10bb9413bf85ec5f2937dbd44c/packages/core/src/utils/ConstantsUtil.ts#L32

   'ASIA/HONG_KONG',

montelaidev avatar May 31 '24 07:05 montelaidev

@metamaskbot update-policies

montelaidev avatar May 31 '24 08:05 montelaidev

Policies updated

metamaskbot avatar May 31 '24 08:05 metamaskbot

Builds ready [5bd1a07]
Page Load Metrics (402 ± 426 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771621042010
domContentLoaded9321463
load473704402888426
domInteractive9311463

metamaskbot avatar Jun 03 '24 08:06 metamaskbot

Builds ready [517c2bc]
Page Load Metrics (53 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911285105
domContentLoaded8201121
load44675384
domInteractive8201121

metamaskbot avatar Jun 03 '24 09:06 metamaskbot

Builds ready [d1e3544]
Page Load Metrics (125 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6714296178
domContentLoaded9391473
load431350125281135
domInteractive9391473

metamaskbot avatar Jun 03 '24 12:06 metamaskbot

Builds ready [98434c9]
Page Load Metrics (51 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6910583115
domContentLoaded8171121
load42665173
domInteractive8171121

metamaskbot avatar Jun 03 '24 16:06 metamaskbot