Mike Purvis

I agree that this would be great to add and document— as it stands, `buildLayer` is a bit of a footgun where you can easily end up re-shipping the same...

Problem line: https://github.com/google/styleguide/blob/db0a26320f3e930c6ea7225ed53539b4fb31310c/cpplint/cpplint.py#L5770 Maybe we just disable `FlagCxx11Features` and `FlagCxx14Features` altogether? @alexhenning Thoughts? For now you can `// NOLINT`, as discussed here: http://wiki.ros.org/roslint#Tips

My link was to the current upstream of `cpplint.py`— it definitely still warns about it. So if we want the warning gone, we have to either drop that entire check...

Unfortunately I'm not able to upload it, but the length of the References field was definitely the most significant and interesting aspect: ``` $ curl http://hydra.clearpath.ai/cache/y94ivgf0ygn86fwsqqhpb83lk7bhprlb.narinfo | grep References |...

I've validated this patch with GCC 12 / log4cxx 1.1.0 on NixOS 23.05. Looks good to me. 🚢

Building our larger workspace with this change has revealed that it definitely still breaks with ROS Python packages using distutils— I'll modify the patch to conditionally import distutils in the...

Here's a first-pass attempt at option 3: https://github.com/ros/catkin/compare/noetic-devel...mikepurvis:issue-1158 I briefly tried the final option, but it became apparent that there are _other_ cases where including `devel/lib` isn't enough— sometimes you...

Boosting this— using a shallow clone also complicates things when you have branches that may change non-linearly (force push), or when hound is pointed at a SHA or switched between...

I believe the path forward on this is migrating to ROS 2, which was built from the start against C++11 so that boost would not be a necessary dependency, at...

We just got bit by this: https://github.com/clearpathrobotics/ros_controllers/commit/f918227e15b863357bb654302563117d636f6230 Seems like no-brainer change to add a one-line constructor to the generated config class, ensuring that config objects are properly initialized upon creation.