rosconsole icon indicating copy to clipboard operation
rosconsole copied to clipboard

Published 20 hours ago • verified publisher icon ros

Compatibility fix for liblog4cxx v0.11-0.13

Open twdragon opened this issue 2 years ago • 5 comments

  • Partially implements (manually) changes suggested both in https://github.com/ros/rosconsole/pull/54 and orphaned commit e3753eec58bf4e76012d019fd307349f94d1d0be
  • Sets up pointer-level compatibility with both new and old log4cxx versions
  • Adds a workaround for API breaking changes in liblog4cxx

I would be very much appreciated if someone would test this code also on liblog4cxx version 0.11 to avoid wrong API calls.

twdragon avatar Nov 14 '22 18:11 twdragon

I've validated this patch with GCC 12 / log4cxx 1.1.0 on NixOS 23.05.

Looks good to me. 🚢

mikepurvis avatar Jul 28 '23 15:07 mikepurvis

This fixes my failing build on Ubuntu 23.10

cameroncooper avatar Nov 05 '23 00:11 cameroncooper

Just confirming this also allows log4cxx versions 0.13 and 1.1.0 on Fedora to work.

tcrider84 avatar Mar 05 '24 23:03 tcrider84

This fixes my failing build on Raspberry Pi OS(Debian 12 bookworm based). Thanks.

ruiqurm avatar Mar 28 '24 08:03 ruiqurm

Is anyone hitting runtime issues with this patch? I'm seeing nodes crash in log4cxx if they call ros::console::set_logger_level more than once.

kjeremy avatar Jul 25 '24 19:07 kjeremy